Enhancing API to support sync_all and sync_platform

RedHatCloudForms / cfme-cloud_services

Red Hat Cloud Services plugin for CloudForms

Apache License 2.0

5 stars 13 forks source link

Enhancing API to support sync_all and sync_platform #26

Closed abellotti closed 5 years ago

abellotti commented 5 years ago

Enhancing the API to support bulk queueing by leveraging the new API Collection actions and extending the sync action including a new sync_all as well as sync_platform for the "core" (non provider) part of the platform via /api/red_hat_cloud_services

POST /api/red_hat_cloud_service_providers - action "sync" with provider_ids specified. POST /api/red_hat_cloud_service_providers - action "sync_all" POST /api/red_hat_cloud_services - action "sync_platform"

abellotti commented 5 years ago

Marking as WIP.

Depends on: https://github.com/ManageIQ/manageiq-api/pull/629 Needs:

[x] Specs

abellotti commented 5 years ago

/cc @agrare @Fryguy doin' the bulk thing via collection actions ...

agrare commented 5 years ago

:+1: looks good

miq-bot commented 5 years ago

Some comments on commits https://github.com/abellotti/cfme-cloud_services/compare/09dced96c74ea3243f7ad9a055b9590d4e7f6fcc~...9a5f95a987e1707c1bcf1a014e51a211a2e215ae

app/controllers/api/red_hat_cloud_service_providers_controller.rb

[ ] :bomb: :boom: :fire: :fire_engine: - 35 - Detected cfme
[ ] :bomb: :boom: :fire: :fire_engine: - 46 - Detected cfme

app/controllers/api/red_hat_cloud_services_controller.rb

[ ] :bomb: :boom: :fire: :fire_engine: - 5 - Detected cfme

spec/requests/red_hat_cloud_service_providers_spec.rb

[ ] :bomb: :boom: :fire: :fire_engine: - 145 - Detected cfme
[ ] :bomb: :boom: :fire: :fire_engine: - 184 - Detected cfme

spec/requests/red_hat_cloud_services_spec.rb

[ ] :bomb: :boom: :fire: :fire_engine: - 9 - Detected cfme

miq-bot commented 5 years ago

Checked commits https://github.com/abellotti/cfme-cloud_services/compare/09dced96c74ea3243f7ad9a055b9590d4e7f6fcc~...9a5f95a987e1707c1bcf1a014e51a211a2e215ae with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 4 files checked, 3 offenses detected

app/controllers/api/red_hat_cloud_service_providers_controller.rb

[ ] :exclamation: - Line 37, Col 5 - Style/RescueStandardError - Avoid rescuing without specifying an error class.
[ ] :exclamation: - Line 48, Col 5 - Style/RescueStandardError - Avoid rescuing without specifying an error class.

app/controllers/api/red_hat_cloud_services_controller.rb

[ ] :exclamation: - Line 7, Col 5 - Style/RescueStandardError - Avoid rescuing without specifying an error class.

abellotti commented 5 years ago

specs added, but they'll fail until https://github.com/ManageIQ/manageiq-api/pull/629 gets merged.

simaishi commented 5 years ago

Ivanchuk backport details:

$ git log -1
commit 51edee9c5d6dbc60bb35ce61d90ad891c4e56ddf
Author: Adam Grare <agrare@redhat.com>
Date:   Wed Jul 31 10:37:26 2019 -0400

    Merge pull request #26 from abellotti/support_sync_all

    Enhancing API to support sync_all and sync_platform

    (cherry picked from commit 523155b290c2a35d892c7108800bab8a7d3cdb1c)