Show Active menu items correctly

RedHatCloudForms / cfme-cloud_services

Red Hat Cloud Services plugin for CloudForms

Apache License 2.0

5 stars 13 forks source link

Show Active menu items correctly #29

Closed PanSpagetka closed 5 years ago

PanSpagetka commented 5 years ago

There is an issue when user select Menu Item under Services items under Red Hat Cloud Services also get selected. It was caused by using same id services for menu items.

https://bugzilla.redhat.com/show_bug.cgi?id=1733489

miq-bot commented 5 years ago

Checked commit https://github.com/PanSpagetka/cfme-cloud_services/commit/8992945dbb01e4292bdd22762a041fbaada6a912 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 2 files checked, 1 offense detected

lib/cfme/cloud_services/engine.rb

[ ] :exclamation: - Line 19, Col 13 - Layout/IndentFirstArrayElement - Use 2 spaces for indentation in an array, relative to the first position after the preceding left parenthesis.

PanSpagetka commented 5 years ago

ping @h-kataria

simaishi commented 5 years ago

Ivanchuk backport details:

$ git log -1
commit f3696526e4b7e816d7af3d7f38c3cd3c6e5cf2b4
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Thu Aug 1 10:24:12 2019 -0400

    Merge pull request #29 from PanSpagetka/show-active-tabs-correctly

    Show Active menu items correctly

    (cherry picked from commit 4d5e66f3a11059151ae57a50d1a3ea92d3ef2db0)

    https://bugzilla.redhat.com/show_bug.cgi?id=1733489