RedHatCloudForms / cfme-cloud_services

Red Hat Cloud Services plugin for CloudForms
Apache License 2.0
5 stars 13 forks source link

Include to Red Hat Cloud services into shortcuts #30

Open PanSpagetka opened 5 years ago

PanSpagetka commented 5 years ago

In My Settings -> Visual (at the bottom of the screen) user can customize what page will show after login. Should we also include Red Hat Cloud Services? It would probably meant make miq_shortcuts.yml also plugable.

@h-kataria @Fryguy @martinpovolny What do you think?

h-kataria commented 5 years ago

@PanSpagetka yes, i think we should look into making miq_shortcuts.yml plugable, that will help with moving v2v shortcuts out of the yaml as well and any such future shortcuts. @GregP has been looking into a BZ to add missing shortcuts, should he wait and not add Red Hat Cloud Services shortcuts into the yaml? @Fryguy @martinpovolny what are your thoughts, i am not sure how much amount of work that is.

GregP commented 5 years ago

The PR is done and ready for review, as of Friday: https://github.com/ManageIQ/manageiq/pull/19062

We do need a solution of some sort, usually a lot of UI work neglects to also provide appropriate refactoring to the mix_shortcuts settings. Though I am not really sure what the solution could/should be. And with more UI changes, and features/menus added/moved/removed, I am sure we’ll be dealing with this on a continuing basis.

On Jul 29, 2019, at 9:33 AM, Harpreet Kataria notifications@github.com wrote:

@PanSpagetka https://github.com/PanSpagetka yes, i think we should look into making miq_shortcuts.yml plugable, that will help with moving v2v shortcuts out of the yaml as well and any such future shortcuts. @GregP https://github.com/GregP has been looking into a BZ to add missing shortcuts, should he wait and not add Red Hat Cloud Services shortcuts into the yaml? @Fryguy https://github.com/Fryguy @martinpovolny https://github.com/martinpovolny what are your thoughts, i am not sure how much amount of work that is.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RedHatCloudForms/cfme-cloud_services/issues/30?email_source=notifications&email_token=AAEG53QUJCLEZV2IO2XQR7TQB4LT5A5CNFSM4IHQMS22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3BINMI#issuecomment-516064945, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEG53VTJ6D2DXLOUBW5MQLQB4LT5ANCNFSM4IHQMS2Q.

agrare commented 5 years ago

@GregP @h-kataria we can't have any reference to RedHatCloudServices in upstream manageiq as it is a downstream only gem

GregP commented 5 years ago

Then we should make mix_shortcuts fix in this case part of the gem, I think.

Should I delete the commit in my PR? It is separate, for a reason (one of the 2).

On Jul 29, 2019, at 9:43 AM, Adam Grare notifications@github.com wrote:

@GregP https://github.com/GregP @h-kataria https://github.com/h-kataria we can't have any reference to RedHatCloudServices in upstream manageiq as it is a downstream only gem

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RedHatCloudForms/cfme-cloud_services/issues/30?email_source=notifications&email_token=AAEG53RCBUNP4JNFASLDTCTQB4MZNA5CNFSM4IHQMS22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3BJIQI#issuecomment-516068417, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEG53TQDSWHFV645DIYRS3QB4MZNANCNFSM4IHQMS2Q.

martinpovolny commented 5 years ago

@GregP @h-kataria we can't have any reference to RedHatCloudServices in upstream manageiq as it is a downstream only gem

Then we need the miq_shortcuts.yml pluggable as @h-kataria wrote or get rid of the whole MiqShortcut idea.

Or... ... at least for now do not add Cloud Services there and simply do not allow it to be the starting page (which probably does not make much sense anyway).

agrare commented 5 years ago

Yeah until we have pluggable miq_shortcuts lets just not have cloud services as an option

miq-bot commented 4 years ago

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!