search

RedHatCloudForms / cfme-cloud_services

Red Hat Cloud Services plugin for CloudForms
Apache License 2.0
5 stars 13 forks source link

Raise error when there is issue on endpoint in ManifestFest #35

Closed lpichler closed 5 years ago

lpichler commented 5 years ago

the other benefit is that it will not continue with sending empty inventory to cloud (I guess this is not needed) on errors with obtaining manifest.

@miq-bot assign @agrare

agrare commented 5 years ago

@lpichler what if we just raised an error if we fail to download the manifest instead of catching the exception and returning {} ?

miq-bot commented 5 years ago

Checked commit https://github.com/lpichler/cfme-cloud_services/commit/6ea5b58cf252606abe8d9895f3370d32b75ac74b with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 2 files checked, 0 offenses detected Everything looks fine. :trophy:

lpichler commented 5 years ago

@lpichler what if we just raised an error if we fail to download the manifest instead of catching the exception and returning {} ?

sure, done, thanks 👍

simaishi commented 5 years ago

Ivanchuk backport details:

$ git log -1
commit 24af8a155087950debfdb2de019ac9461316b36d
Author: Libor Pichler <lpichler@redhat.com>
Date:   Fri Aug 2 12:22:00 2019 +0200

    Raise error when there is issue on endpoint in ManifestFetcher

    (cherry picked from commit 6ea5b58cf252606abe8d9895f3370d32b75ac74b)