Add DOM ids for Cloud Services

RedHatCloudForms / cfme-cloud_services

Red Hat Cloud Services plugin for CloudForms

Apache License 2.0

5 stars 13 forks source link

Closed PanSpagetka closed 5 years ago

PanSpagetka commented 5 years ago

Add DOM ids for Cloud Services

jawatts commented 5 years ago

@PanSpagetka Thanks for adding these in. While this PR is out, I was hoping you can add additional id's the other widgets on the page such as:

It would really help me with automating the tests for these pages. Thanks!!

PanSpagetka commented 5 years ago

@jawatts I have added few more ids, I hope that all active elements should have id now, but please check it if i didn't forget something ;)

jawatts commented 5 years ago

@PanSpagetka just those two more IDs but toherwise looks good, thank you for adding these in!

miq-bot commented 5 years ago

Checked commit https://github.com/PanSpagetka/cfme-cloud_services/commit/f77a4245d0c7c90e49e76e3c48b3116c86a3a28f with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 0 files checked, 0 offenses detected Everything looks fine. :trophy:

PanSpagetka commented 5 years ago

@jawatts <p>s now also have ids ;)

PanSpagetka commented 5 years ago

ping @martinpovolny