Allow file permissions to be set by caller

RedHatCloudForms / cfme-cloud_services

Red Hat Cloud Services plugin for CloudForms

Apache License 2.0

5 stars 13 forks source link

Allow file permissions to be set by caller #42

Closed agrare closed 5 years ago

agrare commented 5 years ago

The file that gets created by Tempfile always has access mode 0600 and cannot be overridden by the caller. This isn't always ideal so provide an option to the caller of modifying the access mode after the file is created.

miq-bot commented 5 years ago

Checked commit https://github.com/agrare/cfme-cloud_services/commit/5dbb413ca4a71031ccaa041d47c70fa567785608 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 2 files checked, 1 offense detected

lib/cfme/cloud_services/inventory_sync.rb

[ ] :warning: - Line 32, Col 83 - Lint/UnusedMethodArgument - Unused method argument - miq_task_id.

agrare commented 5 years ago

:+1: thanks @abellotti

agrare commented 5 years ago

https://bugzilla.redhat.com/show_bug.cgi?id=1744606

simaishi commented 5 years ago

Ivanchuk backport details:

$ git log -1
commit 8adfb97c7823e2e0de55861dfda8f19255146fff
Author: Alberto Bellotti <abellotti@users.noreply.github.com>
Date:   Mon Aug 19 11:39:21 2019 -0400

    Merge pull request #42 from agrare/allow_file_permissions_to_be_set

    Allow file permissions to be set by caller

    (cherry picked from commit 77b85429fb36cb8ea09e10948d6dc89e60df35df)

    https://bugzilla.redhat.com/show_bug.cgi?id=1744606