Add method for inventory upload to insights uploader

RedHatCloudForms / cfme-cloud_services

Red Hat Cloud Services plugin for CloudForms

Apache License 2.0

5 stars 13 forks source link

Add method for inventory upload to insights uploader #7

Closed lpichler closed 5 years ago

lpichler commented 5 years ago

inventory is collected to json file
this json file is packed to tar.gz
insights-client is used for sending to cloud

How to test it (if you have ManageIQ::Providers::Vmware::InfraManager provider):

target = ManageIQ::Providers::Vmware::InfraManager.first
Cfme::CloudServices::DataCollector.collect(target)

Fryguy commented 5 years ago

This is looking great @lpichler !

lpichler commented 5 years ago

@Fryguy thanks for you comments - I added some specs and the other method: sending thru insights-client as I discussed with @gtanzillo. So this PR can be reviewed again.

Now I left here both ways - if insights-clients will fail then http request is used - but I guess it is a subject for a discussion: - if I should leave here just insights-client method or leave it as I have it now.

thanks !

lpichler commented 5 years ago

@agrare - I did changes according to your suggestions, thanks for you review!

I also removed method with using http - because it requires more things (account number from subscription , 3scale request, ..) and it looks like it is enough to use insights client for uploading - if let me know - and I can add here both methods.

agrare commented 5 years ago

and it looks like it is enough to use insights client for uploading - if let me know - and I can add here both methods.

Completely agree, I'm good with standardizing on insights-client for upload