Hard dep on python lex, Spacebar Preview of slide.

RedHatEMEA / satools

18 stars 7 forks source link

Hard dep on python lex, Spacebar Preview of slide. #60

Closed jamesread closed 11 years ago

jamesread commented 11 years ago

This is a tiny pull request which just includes 2 simple commits;

ee28ac1 Hard dep on python lex libraries, required to make. 013b866 Potential fix for issue #48 - Spacebar Preview of Slide.

I didn't branch to separate these two issues because they are so small, but I'll try that with my next PR :)

jim-minter commented 11 years ago

ee28ac1 is good and has been applied. Thanks. 013b866 isn't right - the aim is for space to open/close the zoom window. enter/esc already does this. I /think/ the place to edit is just ikeydown in juno/app/static/controller/SlidesController.js, i.e.: if(e.keyCode == e.ESC && this.getSlidezoom()) { and if(e.keyCode == e.ENTER && !this.getSlidezoom()) {

jamesread commented 11 years ago

Oh how silly. I thought the issue was "spacebar to advance the slide". No worries, will fix tomorrow.

jim-minter commented 11 years ago

-ETIMEDOUT