RedHatGov / product-demos

GNU General Public License v3.0
31 stars 21 forks source link

Updates to node1 #42

Closed calvingsmith closed 2 years ago

calvingsmith commented 2 years ago

Also, request that the satellite image (don't know how to log into instance) get's the following run on it:

satellite-installer --enable-foreman-plugin-remote-execution-cockpit

calvingsmith commented 2 years ago

OK finished up the review comments. Switched to rex_user instead of ansible_user as need to configure satellite as well to get it to work right, will leave that as an issue if it's OK.

calvingsmith commented 2 years ago

cool, working on the web console playbook in the linux section rn

On Thu, Nov 17, 2022 at 12:16 PM willtome @.***> wrote:

@.**** requested changes on this pull request.

@calvingsmith https://github.com/calvingsmith as discussed...

  1. let's remove the web console playbook from this PR
  2. the activation key task (line 38) in collections/ansible_collections/demo/satellite/roles/register_host/tasks/main.yml as it is now in the variables file.
  3. remove cockpit_packages line from satellite/server_register.yml

I think we'll be ready to merge after these changes

— Reply to this email directly, view it on GitHub https://github.com/RedHatGov/product-demos/pull/42#pullrequestreview-1184730021, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAV4GWH6NRSM5HKLMRVBZDWIZR5LANCNFSM6AAAAAAR7DMQLI . You are receiving this because you were mentioned.Message ID: @.***>

-- Calvin Smith | Senior Solutions Architect Public Sector Division | Red Hat @.***

RED HAT | TRIED. TESTED. TRUSTED. Every single executive department in the U.S. federal government runs Red Hat in their datacenters. Find out why at Trusted | Red Hat http://www.redhat.com/en/about/trusted

willtome commented 2 years ago

@calvingsmith awesome PR! Thank you for the collaboration and for helping to improve this community.