RedHatGov / redhatgov.github.io

RedHatGov website
http://redhatgov.io
GNU General Public License v3.0
135 stars 333 forks source link

Hugo binaries in repo don't indicate platform (i.e. linux vs mac) #168

Closed jaredhocutt closed 4 years ago

jaredhocutt commented 5 years ago

There is a hugo binary in the root of the repo that is compiled for macOS. The hugo binary in the bin directory is compiled for Linux.

These binaries should both be placed under the bin directory and renamed to indicate which is which.

For example:

NOTE: If you change the name of <repo>/bin/hugo, this will break the TravisCI build unless you also update it to use the path of whatever the new filename is.

jaredhocutt commented 5 years ago

Thinking on this a bit more, a good way to solve this would be to use a containerized version of hugo and have a simple script that users can run that will map things correctly.

dudash commented 4 years ago

FYI - I just added /bin/hugo-mac64 but didn't change the name of the linux repo. This change will come in with the service mesh workshop PR - probably next week.

kenmoini commented 4 years ago

This can likely be closed now as well...Hugo binary has been versioned, updated, and symlinked for the different archs.

ajacocks commented 4 years ago

Closed.