search

RedHatGov / serverless-workshop-dashboard

Lab guides for a workshop on OpenShift Serverless (Knative)
Apache License 2.0
5 stars 4 forks source link

Lab1.4 Fix the 'Deploy the updated service' #52

Closed theckang closed 3 years ago

theckang commented 3 years ago
  1. kn service update does not need the image
  2. Break out the 'create' alternative
  3. '-f' is not force

In some cases, the user didn't see the Pythonistas even when the service was updated. It required force create to fix the issue.

jkeam commented 3 years ago

--force https://github.com/knative/client/blob/c62842355a532a4c69dccdb2cc6dc1b5f1d0f937/pkg/kn/commands/service/create.go

jkeam commented 3 years ago

Maybe we should just change the update to create?

jkeam commented 3 years ago

PR https://github.com/RedHatGov/serverless-workshop-dashboard/pull/62

jkeam commented 3 years ago

PR Merged