RedHatGov / service-mesh-workshop-code

:memo: A demo app to use in the Service Mesh workshop
Apache License 2.0
16 stars 17 forks source link

When using the fake user, adding an item to a board results in the display of 'undefined' as the username #11

Open mandibuswell opened 2 years ago

mandibuswell commented 2 years ago

Describe the bug When using the fake user, adding an item to a board results in the display of 'undefined' as the username

To Reproduce Using the FAKE USER Sarah Add a new board Add an item to the board Observe the text 'undefined' in bold above the text you have just added to the board as shown in the attached screenshot.

Expected behavior If you are logged in I expect you see the Username, however as this is a fake user - I expect to see Sarah here instead of 'undefined'.

Screenshots If applicable, add screenshots to help explain your problem. Screen Shot 2022-03-01 at 8 35 57 AM

Additional context Undefined makes it look like a code bug and for a workshop this can be distracting.

dudash commented 2 years ago

thanks @mandibuswell - good catch. For reference, here's the offending code: https://github.com/RedHatGov/service-mesh-workshop-code/blob/workshop-stable/code/app-ui/views/shared.pug#L39

Need to figure out why username isn't getting pulled into the owner variable there.