search

RedHatGov / sre-workshop-dashboard

Lab guides for a workshop on Site Reliability Engineering (SRE)
Apache License 2.0
3 stars 4 forks source link

Lab 2.1 Reference to %username% is ambiguous #6

Closed bradscalio closed 4 years ago

bradscalio commented 4 years ago

[Lab 2.1 Getting Started](git clone https://github.com/RedHatGov/sre-workshop-code.git) references oc get pods -n '%username%'-istio but the value of %username% is a bit ambiguous if this can be replaced if Lab 2.1 will be used in the modules for the workshop ideally replace it with the actual student username value dynamically if possible.

theckang commented 4 years ago

%username% should dynamically replace with the homeroom user's name (when viewed in homeroom). Did this not render correctly?

bradscalio commented 4 years ago

It did, because Lab 2.1 was missing I went to the code in github and then when going back to Lab 3.1 I see that indeed the variable is reaplaced this was just me opening issues as I go.

For the labs in homeroom the username does render, close issue with no action recommended.

theckang commented 4 years ago

Gotcha, yep, I forgot to include Lab 2.1 (ref: #4) in homeroom. Closing this issue.