search

RedHatInsights / aiops-insights-clustering

Clustering of systems
GNU General Public License v3.0
1 stars 14 forks source link

make ceph work #17

Closed durandom closed 6 years ago

durandom commented 6 years ago

implement ceph storage api similar to s3

@tumido please review

durandom commented 6 years ago

Actually the code really is basically the S3 code. In a follow up we should make the ceph code use the s3 stuff directly. Or use proper inheritance and not this conditional import hack?!

But this should do for now

tumido commented 6 years ago

Yes, maybe implementing this as classes instead of plain modules can help. But.. that's not in scope of this PR for sure. :wink:

durandom commented 6 years ago

@tumido thanks for the review. merge now?

durandom commented 6 years ago

@tumido you should be able to merge now