search

RedHatInsights / insights-api-common-rails

Header, Encryption, RBAC, Serialization, Pagination and other common behavior for Insights microservices built with Rails
Apache License 2.0
3 stars 25 forks source link

Allow for other content types other than application/json #134

Closed mkanoor closed 4 years ago

mkanoor commented 4 years ago

Rails can handle multiple content types like application/json, multipart/form-data. It parses them and builds the ActionController:: Parameters with the params that includes the path_parameters and query_parameters. During a post call where we try to get just the body parameters by reparsing the body, if we just exclude the path parameters from the params we wont have to reparse the request.body. Also the correct content-type needs to be sent to the openapi-parser.

Fixes #116

miq-bot commented 4 years ago

Checked commits https://github.com/mkanoor/manageiq-api-common/compare/65a8d76612fe2852f7f65916fbca16cd073cb9d6~...1cf5a0d5948fc7e580f987b7a140c552a7d8df38 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 2 files checked, 0 offenses detected Everything looks fine. :cake:

miq-bot commented 4 years ago

This pull request is not mergeable. Please rebase and repush.