[WIP] Removed references to Policy objects

RedHatInsights / insights-api-common-rails

Header, Encryption, RBAC, Serialization, Pagination and other common behavior for Insights microservices built with Rails

Apache License 2.0

3 stars 25 forks source link

[WIP] Removed references to Policy objects #137

Closed mkanoor closed 4 years ago

mkanoor commented 4 years ago

https://projects.engineering.redhat.com/browse/SSP-963 Depends on https://github.com/RedHatInsights/insights-rbac-api-client-ruby/pull/4 Based on https://github.com/RedHatInsights/insights-rbac/pull/156

Instead of adding roles to group via Policies now we can directly add role to a group or delete a role from a group

miq-bot commented 4 years ago

Checked commits https://github.com/mkanoor/manageiq-api-common/compare/ff34d783138368cad78d540e7928b47a0e015b4c~...e9134ccab95b5fc0251492ac247ab8665d738800 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 10 files checked, 2 offenses detected

[ ] :bomb: :boom: :fire: :fire_engine: - Linter/Yaml - missing config files

lib/insights/api/common/rbac/seed.rb

[ ] :exclamation: - Line 15, Col 15 - Style/RedundantBegin - Redundant begin block detected.

mkanoor commented 4 years ago

@eclarizio @syncrou Please review

mkanoor commented 4 years ago

@gmcculloug @syncrou Since this PR removes Policy objects we could delay this PR and create a new PR that uses add_roles_to_group only during seeding. Since we would be using local AccessControlEntries (ACE) we don't need to be adding the sharing roles into the group anymore. This will allow us to stay backward compatibility and have the new sharing implemented locally. If we agree I can pull out the pieces from this PR that uses the new add_roles_to_group for the seeding process.

mkanoor commented 4 years ago

Closed in favor of https://github.com/RedHatInsights/insights-api-common-rails/pull/138 which has the seeding pieces