search

RedHatInsights / insights-api-common-rails

Header, Encryption, RBAC, Serialization, Pagination and other common behavior for Insights microservices built with Rails
Apache License 2.0
3 stars 25 forks source link

Don't forget to log the error too... #147

Closed bdunne closed 4 years ago

bdunne commented 4 years ago

Without this change, errors are not logged and it's very difficult to get the stack trace.

miq-bot commented 4 years ago

Checked commit https://github.com/bdunne/manageiq-api-common/commit/7f4526587830cd9c3b5986d574317c4d22ada9b8 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 1 file checked, 0 offenses detected Everything looks fine. :star:

mkanoor commented 4 years ago

👍 We need this feature badly in catalog-api and added the logging there and re-raising the error