search

RedHatInsights / insights-api-common-rails

Header, Encryption, RBAC, Serialization, Pagination and other common behavior for Insights microservices built with Rails
Apache License 2.0
3 stars 25 forks source link

Allow filtering of tag join records based on tag attributes #149

Closed bdunne closed 4 years ago

bdunne commented 4 years ago

@kbrock Please review

abellotti commented 4 years ago

@bdunne looks good, may add the specs for the tag filtering. Thanks!!

miq-bot commented 4 years ago

Checked commits https://github.com/bdunne/manageiq-api-common/compare/7b71b5f1673d83f5f0f83aa6d185f16097219e44~...419051ea32c28e28b17bdafa36004741bbab357e with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 5 files checked, 0 offenses detected Everything looks fine. :trophy:

bdunne commented 4 years ago

@bdunne looks good, may add the specs for the tag filtering. Thanks!!

I added tests for the undocumented attributes. I'll add tests for the virtual_delegates in the other PR.