search

RedHatInsights / insights-api-common-rails

Header, Encryption, RBAC, Serialization, Pagination and other common behavior for Insights microservices built with Rails
Apache License 2.0
3 stars 25 forks source link

Set the limit to be the max specified in the openapi.json #151

Closed mkanoor closed 4 years ago

mkanoor commented 4 years ago

https://github.com/RedHatInsights/insights-rbac/blob/e8816dc36041945a62b674203b9062abfcf9ae6d/docs/source/specs/openapi.json#L1491

The default of 10 causes to many back and forth between the RBAC service and the clients.

mkanoor commented 4 years ago

@syncrou Please review

mkanoor commented 4 years ago

The generated client gem doesn't have a constant to store this value it is hard coded like here https://github.com/RedHatInsights/insights-rbac-api-client-ruby/blob/d63a05de04c910ed87292e3ff2d65a5aaa09f0fd/lib/rbac-api-client/api/principal_api.rb#L43 from the openapi.json when the client is generated

miq-bot commented 4 years ago

Checked commit https://github.com/mkanoor/manageiq-api-common/commit/aa7db5b9a29864a044c5f102a8a9d4080a0cbcee with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 2 files checked, 2 offenses detected

lib/insights/api/common/rbac/service.rb

mkanoor commented 4 years ago

asking the RBAC team if they can add a feature to filter groups based on one or more uuids. Hence closing