search

RedHatInsights / insights-api-common-rails

Header, Encryption, RBAC, Serialization, Pagination and other common behavior for Insights microservices built with Rails
Apache License 2.0
3 stars 25 forks source link

Add openapi-validator.sh script for reference from API repos. #202

Closed gmcculloug closed 4 years ago

gmcculloug commented 4 years ago

Part of fixing #201

Move the openapi-validator.sh script to a common location for all the API repos to access.

dippy-bot commented 4 years ago

Checked commit https://github.com/gmcculloug/insights-api-common-rails/commit/cce78bef928bb6bc0a1cba09ae4d7e34b2ce4844 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :cookie:

lindgrenj6 commented 4 years ago

I think we need to add .travis_scripts/ to the gemspec here: https://github.com/RedHatInsights/insights-api-common-rails/blob/bc964c7ec61028e311215b5df29d368c2ca30333/insights-api-common.gemspec#L14

Looking at it now it doesn't look like it's included. Of course this all depends if we decide to download it from github or use the version bundled with the gem.

gmcculloug commented 4 years ago

@lindgrenj6 Good point. I did end up switching to downloading the script from the master branch so we probably can avoid adding it to the gem unless others thing it should be there for some reason. For now, I'll leave the PR as-is and can update if there is more feedback on this topic.