RedHatInsights / insights-api-common-rails

Header, Encryption, RBAC, Serialization, Pagination and other common behavior for Insights microservices built with Rails
Apache License 2.0
3 stars 25 forks source link

Fixed to log error messages in with_request block #208

Closed hsong-rh closed 4 years ago

hsong-rh commented 4 years ago

When exception is raised, the place to log error messages has lost the request context. This PR moves the log call within request context.

hsong-rh commented 4 years ago

@lindgrenj6 @mkanoor Please review

dippy-bot commented 4 years ago

Checked commit https://github.com/hsong-rh/manageiq-api-common/commit/64057f6900162cf3b1f17d0860b0e05c1f36b275 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.35.0, and yamllint 3 files checked, 0 offenses detected Everything looks fine. :star: