RedHatInsights / insights-api-common-rails

Header, Encryption, RBAC, Serialization, Pagination and other common behavior for Insights microservices built with Rails
Apache License 2.0
3 stars 25 forks source link

Add rubocop_base.yml for common rubocop rules #210

Closed lindgrenj6 closed 3 years ago

lindgrenj6 commented 3 years ago

https://issues.redhat.com/browse/RHCLOUD-10237

Rather than making a new repo lets use api-common as the main repo. We will need to update ALL THE THINGS after this is merged though!

eclarizio commented 3 years ago

@lindgrenj6 I'm fine with this if we want to keep it in here instead of the new "manageiq-style" repo, but I think with this change we have to update rubocop on dippy-bot to a later version. I made a similar PR for Catalog: https://github.com/RedHatInsights/catalog-api/pull/844 but dippy-bot is also complaining about missing linter config files.

lindgrenj6 commented 3 years ago

@eclarizio yeah I think that is one thing we are going to try to do now/in the future. It would be really nice to upgrade to rubocop 1.0 since that was just released recently.

dippy-bot commented 3 years ago

Some comments on commit https://github.com/lindgrenj6/insights-api-common-rails/commit/fb07de3316973db064ecfb1eeea6c555f7bea9bb

.rubocop_base.yml

dippy-bot commented 3 years ago

Checked commit https://github.com/lindgrenj6/insights-api-common-rails/commit/fb07de3316973db064ecfb1eeea6c555f7bea9bb with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.35.0, and yamllint 2 files checked, 1 offense detected

**

syncrou commented 3 years ago

@eclarizio @lindgrenj6 with the questions about Dippy Bot, that doesn't hold this PR up does it?

eclarizio commented 3 years ago

@syncrou I fixed dippy-bot this morning, so that should be good now, though it is currently pointing at the manageiq-style rules, not these (which makes sense since these haven't been merged yet anyway).