Closed lindgrenj6 closed 3 years ago
@lindgrenj6 I'm fine with this if we want to keep it in here instead of the new "manageiq-style" repo, but I think with this change we have to update rubocop on dippy-bot to a later version. I made a similar PR for Catalog: https://github.com/RedHatInsights/catalog-api/pull/844 but dippy-bot is also complaining about missing linter config files.
@eclarizio yeah I think that is one thing we are going to try to do now/in the future. It would be really nice to upgrade to rubocop 1.0 since that was just released recently.
.rubocop_base.yml
pp
. Remove all debugging statements.puts
. Remove all debugging statements.**
@eclarizio @lindgrenj6 with the questions about Dippy Bot, that doesn't hold this PR up does it?
@syncrou I fixed dippy-bot this morning, so that should be good now, though it is currently pointing at the manageiq-style rules, not these (which makes sense since these haven't been merged yet anyway).
https://issues.redhat.com/browse/RHCLOUD-10237
Rather than making a new repo lets use api-common as the main repo. We will need to update ALL THE THINGS after this is merged though!