search

RedHatInsights / insights-api-common-rails

Header, Encryption, RBAC, Serialization, Pagination and other common behavior for Insights microservices built with Rails
Apache License 2.0
3 stars 25 forks source link

Release v5.0.0 #215

Closed lindgrenj6 closed 3 years ago

lindgrenj6 commented 3 years ago

Debating naming this release 4.2.0 instead of 4.1.6 due to the fact that params_for_update behavior is changing. Theoretically it should be a bug fix, but the behavior is changing nonetheless.

EDIT: After talking with Drew we decided to release 5.0 instead of a minor release due to the fact this is a breaking change that could introduce small intricacies in catalog and other apps using this code.

cc @hsong-rh @eclarizio @syncrou

DEPENDS ON:

lindgrenj6 commented 3 years ago

@eclarizio We are doing a major release with #213 being in this release - I would check against that branch in catalog and see if everything is still working, and then update your Gemfile accordingly.

dippy-bot commented 3 years ago

Checked commit https://github.com/lindgrenj6/insights-api-common-rails/commit/70d5cea26867f015a76a8aef2820063742bad80e with ruby 2.5.7, rubocop 0.82.0, haml-lint 0.35.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :cookie: