search

RedHatInsights / insights-api-common-rails

Header, Encryption, RBAC, Serialization, Pagination and other common behavior for Insights microservices built with Rails
Apache License 2.0
3 stars 25 forks source link

chore(deps): permissive prometheus_exporter dependency #218

Open vkrizan opened 3 years ago

vkrizan commented 3 years ago

allowing to have versions 0.4 up to but not inluding 1.0 starting with version 0.4.5.

vkrizan commented 3 years ago

@slemrmartin, @lindgrenj6, @syncrou, would you guys be able to have a look. (I was unable to set reviewers.) Thanks.

vkrizan commented 3 years ago

Hmm, there would be more changes to deps required to alleviate the version restrictions.

dippy-bot commented 3 years ago

Checked commit https://github.com/vkrizan/insights-api-common-rails/commit/fd34b2610450d1c0a11cbd61c4369d59dab548ed with ruby 2.5.7, rubocop 0.82.0, haml-lint 0.35.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :+1:

slemrmartin commented 3 years ago

@vkrizan have you tried the gem with prometheus in app-interface, is higher version compatible? Basically how it should influence version of this gem (patch/minor)?

vkrizan commented 3 years ago

@slemrmartin, we use prometheus_exporter 0.5.1 in Compliance in production. I can lock it up to 0.6.

lindgrenj6 commented 3 years ago

Hey @vkrizan, thanks for the PR. Looking at this it basically locks us at 0.4.z, not up to 0.y.z.

If we want to lock it to basically anything pre-1.0 but greater than 0.4.5 we could lock like this: ~ 0.4, >= 0.4.5

vkrizan commented 3 years ago

@lindgrenj6 the suggestion looks good.

There were more of these that need to be updated in similar manor to allow us to consume the lib.