search

RedHatInsights / insights-chrome

Chroming for Insights apps
MIT License
26 stars 131 forks source link

Left hand nav and main content scroll together #201

Closed dlabrecq closed 5 years ago

dlabrecq commented 5 years ago

The left hand navigation pane, header, and main page content scroll together for Cost Management. I noticed other apps under Insights do not do this. Is this an Insights issue or something missed in Cost Management?

To Reproduce Steps to reproduce the behavior:

  1. Go to Cost Management
  2. Go to AWS/OpenShift Details
  3. Scroll down
  4. See Left hand nav, page header, & main page content scroll together

*Expected behavior** We should only be scrolling the app/table data.

Screenshots screenshot from 2019-02-24 23-53-57

ryelo commented 5 years ago

@dlabrecq After digging around, the reason this is happening is because you're setting height variables in the root.

https://github.com/project-koku/koku-ui/blob/447e0b36e9bebf66fd7247992a1e1d2e2d74c58a/src/styles/global.css#L5

html,
body,
#root {
  width: 100%;
  height: 100%;
}

If you edit the DOM and remove the #root { height: 100% } it works on my end.

ryelo commented 5 years ago

@dlabrecq Is this still an issue or can this be closed?

dlabrecq commented 5 years ago

Yes, this can be closed. I appreciate your help!