search

RedHatInsights / insights-chrome

Chroming for Insights apps
MIT License
26 stars 131 forks source link

Hide global filter when disabled. #2826

Closed Hyperkid123 closed 6 months ago

Hyperkid123 commented 6 months ago

Jira: https://issues.redhat.com/browse/RHCLOUD-31582

Uses the isDisabled prop to remove the global filter rather than just disabling the dropdown.

fhlavac commented 6 months ago

The tests probably need to be updated, otherwise looks good!

Hyperkid123 commented 6 months ago

Oh yeah.

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 63.41%. Comparing base (38bb1f8) to head (ff692a1).

:exclamation: Current head ff692a1 differs from pull request most recent head 7a69b49. Consider uploading reports for the commit 7a69b49 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2826/graphs/tree.svg?width=650&height=150&src=pr&token=GuRwyW1uUf&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights)](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2826?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) ```diff @@ Coverage Diff @@ ## master #2826 +/- ## ========================================== + Coverage 63.32% 63.41% +0.08% ========================================== Files 198 198 Lines 4278 4280 +2 Branches 775 776 +1 ========================================== + Hits 2709 2714 +5 + Misses 1560 1557 -3 Partials 9 9 ``` | [Files](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2826?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) | Coverage Δ | | |---|---|---| | [src/components/GlobalFilter/GlobalFilterMenu.tsx](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2826?src=pr&el=tree&filepath=src%2Fcomponents%2FGlobalFilter%2FGlobalFilterMenu.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL2NvbXBvbmVudHMvR2xvYmFsRmlsdGVyL0dsb2JhbEZpbHRlck1lbnUudHN4) | `6.25% <ø> (ø)` | | | [src/components/GlobalFilter/GlobalFilter.tsx](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2826?src=pr&el=tree&filepath=src%2Fcomponents%2FGlobalFilter%2FGlobalFilter.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL2NvbXBvbmVudHMvR2xvYmFsRmlsdGVyL0dsb2JhbEZpbHRlci50c3g=) | `43.75% <83.33%> (+6.65%)` | :arrow_up: |