search

RedHatInsights / insights-chrome

Chroming for Insights apps
MIT License
26 stars 131 forks source link

update insights bundle title suffix to RHEL #2828

Closed mkholjuraev closed 6 months ago

mkholjuraev commented 6 months ago

interact team is working on consolidating the insights page titles RHINENG-9387. It requires those page titles to have 'RHEL' instead of the 'Red hat insights' suffix at the end. This PR makes this change in chrome repo so that the default suffix is applied to all insights apps in the bundle.

mkholjuraev commented 6 months ago

@Hyperkid123 I am wondering if this commit has already been released. I am trying this out locally with another tenant app, but I still see the old "Red Hat insights" suffix.

Hyperkid123 commented 6 months ago

Not in prod. Also apps can can set their titles independently if that is where you see it.

mkholjuraev commented 6 months ago

@Hyperkid123 Sorry for the confusion, I meant the stage env. I am testing out the stage environment, with a tent app without the page title suffix. Chrome app is still adding the old 'Red Hat Insights' suffix instead of the new 'RHEL'.

I tried my commit locally by running the tenant app with the local chrome, it works fine.

Hyperkid123 commented 6 months ago

@mkholjuraev On this page: https://console.stage.redhat.com/preview/insights/dashboard#SIDs=&tags=

I get this output when I check the method you updated: 

window.insights.chrome.getBundleData()
{bundleId: 'insights', bundleTitle: 'RHEL'}

And the tab title is indeed Dashboard | RHEL.

Seems ok to me. Is it the Chrome app adding it? Can't it be the app changing the title internally?