Closed florkbr closed 1 month ago
Attention: Patch coverage is 14.58333%
with 82 lines
in your changes are missing coverage. Please review.
Project coverage is 62.47%. Comparing base (
3194dee
) to head (c040274
). Report is 13 commits behind head on master.:exclamation: Current head c040274 differs from pull request most recent head ca648e6. Consider uploading reports for the commit ca648e6 to get more accurate results
@florkbr do we want this to be baked into chrome? Can this be its own module?
@Hyperkid123 I don't think it necessarily needs to be baked into chrome - I just started from where the UI lived today.
Do you have any suggestions or thoughts on where the new module could/should be placed?
@florkbr a new module :) Like the widget UI.
When deploying this in our itless env I'm seeing the same pod crash loop as noted in: https://github.com/RedHatInsights/insights-chrome/pull/2922
/retest
@Hyperkid123 I removed the changes to frontend.yml
for now. Let me know if you think this needs anything else! I'll likely still need to follow up with some styling tweaks on the IP whitelist UI itself - but the major flows seems to be working for me.
The PR build pipeline is still failing due to the CrashLoopBackOff
issue mentioned earlier. I've started a thread in our dev-prod channel and will continue investigating on https://github.com/RedHatInsights/insights-chrome/pull/2922
Depends on: https://github.com/RedHatInsights/chrome-service-backend/pull/668
Utilizes mbop changes here: https://github.com/RedHatInsights/mbop/pull/105
Adds a simple UI to the manage satellites page to add/remove IP address(es) WRT to our itless environments.
~Marking as draft until I manually try the API requests in this PR via postman on pre-prod env.~ EDIT: verified API requests after deploying