RedHatInsights / insights-chrome

Chroming for Insights apps
MIT License
27 stars 130 forks source link

Adjust PDF API #2845

Closed Hyperkid123 closed 3 months ago

Hyperkid123 commented 3 months ago

Part of: https://issues.redhat.com/browse/RHCLOUD-32912

Adjust the requestPdf argument types to match the generator API.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 63.61%. Comparing base (34cd2da) to head (bb30c1f).

:exclamation: Current head bb30c1f differs from pull request most recent head c5da8d1

Please upload reports for the commit c5da8d1 to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2845/graphs/tree.svg?width=650&height=150&src=pr&token=GuRwyW1uUf&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights)](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2845?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) ```diff @@ Coverage Diff @@ ## master #2845 +/- ## ======================================= Coverage 63.61% 63.61% ======================================= Files 201 201 Lines 4318 4318 Branches 778 778 ======================================= Hits 2747 2747 Misses 1562 1562 Partials 9 9 ``` | [Files](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2845?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) | Coverage Δ | | |---|---|---| | [src/pdf/requestPdf.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2845?src=pr&el=tree&filepath=src%2Fpdf%2FrequestPdf.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL3BkZi9yZXF1ZXN0UGRmLnRz) | `24.32% <33.33%> (ø)` | |