RedHatInsights / insights-chrome

Chroming for Insights apps
MIT License
26 stars 131 forks source link

Fixed title and route in Notifications menu #2847

Closed radekkaluzik closed 5 months ago

radekkaluzik commented 5 months ago

Change link title from "View event log" to "View notifications log" and change routing from "/settings/notifications/eventlog" to "/settings/notifications/notificationslog"

https://issues.redhat.com/browse/RHCLOUD-32790

Before: image

After: image

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 63.61%. Comparing base (f1bd75c) to head (9d5c294).

:exclamation: Current head 9d5c294 differs from pull request most recent head a6f2ca1

Please upload reports for the commit a6f2ca1 to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2847/graphs/tree.svg?width=650&height=150&src=pr&token=GuRwyW1uUf&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights)](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2847?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) ```diff @@ Coverage Diff @@ ## master #2847 +/- ## ======================================= Coverage 63.61% 63.61% ======================================= Files 201 201 Lines 4318 4318 Branches 778 778 ======================================= Hits 2747 2747 Misses 1562 1562 Partials 9 9 ``` | [Files](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2847?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) | Coverage Δ | | |---|---|---| | [...ponents/NotificationsDrawer/DrawerPanelContent.tsx](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2847?src=pr&el=tree&filepath=src%2Fcomponents%2FNotificationsDrawer%2FDrawerPanelContent.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL2NvbXBvbmVudHMvTm90aWZpY2F0aW9uc0RyYXdlci9EcmF3ZXJQYW5lbENvbnRlbnQudHN4) | `4.76% <0.00%> (ø)` | |
radekkaluzik commented 5 months ago

/retest