RedHatInsights / insights-chrome

Chroming for Insights apps
MIT License
27 stars 130 forks source link

Enable scoped UI id header to same origin. #2854

Closed Hyperkid123 closed 3 months ago

Hyperkid123 commented 3 months ago

Part of: https://issues.redhat.com/browse/RHCLOUD-32526, https://issues.redhat.com/browse/RHCLOUD-32982

Only allows the new UI header to be sent to the same origin of the UI.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 61.74%. Comparing base (5c386ea) to head (e05ccc0).

:exclamation: Current head e05ccc0 differs from pull request most recent head a46d337

Please upload reports for the commit a46d337 to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2854/graphs/tree.svg?width=650&height=150&src=pr&token=GuRwyW1uUf&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights)](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2854?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) ```diff @@ Coverage Diff @@ ## master #2854 +/- ## ========================================== - Coverage 61.74% 61.74% -0.01% ========================================== Files 204 204 Lines 4538 4540 +2 Branches 856 856 ========================================== + Hits 2802 2803 +1 - Misses 1725 1726 +1 Partials 11 11 ``` | [Files](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2854?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) | Coverage Δ | | |---|---|---| | [src/chrome/create-chrome.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2854?src=pr&el=tree&filepath=src%2Fchrome%2Fcreate-chrome.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL2Nocm9tZS9jcmVhdGUtY2hyb21lLnRz) | `45.12% <ø> (ø)` | | | [src/auth/ChromeAuthContext.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2854?src=pr&el=tree&filepath=src%2Fauth%2FChromeAuthContext.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL2F1dGgvQ2hyb21lQXV0aENvbnRleHQudHM=) | `26.66% <0.00%> (-1.91%)` | :arrow_down: | | [src/auth/OIDCConnector/OIDCSecured.tsx](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2854?src=pr&el=tree&filepath=src%2Fauth%2FOIDCConnector%2FOIDCSecured.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL2F1dGgvT0lEQ0Nvbm5lY3Rvci9PSURDU2VjdXJlZC50c3g=) | `65.55% <0.00%> (-0.74%)` | :arrow_down: | | [src/utils/iqeEnablement.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2854?src=pr&el=tree&filepath=src%2Futils%2FiqeEnablement.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL3V0aWxzL2lxZUVuYWJsZW1lbnQudHM=) | `69.60% <66.66%> (+0.79%)` | :arrow_up: |
Hyperkid123 commented 3 months ago

/retest