RedHatInsights / insights-chrome

Chroming for Insights apps
MIT License
27 stars 130 forks source link

Migrate notifications reducer to Jotai #2857

Closed Hyperkid123 closed 3 months ago

Hyperkid123 commented 3 months ago

Jira: https://issues.redhat.com/browse/RHCLOUD-33103

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.

Project coverage is 62.91%. Comparing base (19729f0) to head (89902ba).

:exclamation: Current head 89902ba differs from pull request most recent head 8dc3728

Please upload reports for the commit 8dc3728 to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2857/graphs/tree.svg?width=650&height=150&src=pr&token=GuRwyW1uUf&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights)](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2857?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) ```diff @@ Coverage Diff @@ ## master #2857 +/- ## ========================================== + Coverage 61.75% 62.91% +1.16% ========================================== Files 205 206 +1 Lines 4542 4509 -33 Branches 856 845 -11 ========================================== + Hits 2805 2837 +32 + Misses 1726 1661 -65 Partials 11 11 ``` | [Files](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2857?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) | Coverage Δ | | |---|---|---| | [src/components/Header/Tools.tsx](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2857?src=pr&el=tree&filepath=src%2Fcomponents%2FHeader%2FTools.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL2NvbXBvbmVudHMvSGVhZGVyL1Rvb2xzLnRzeA==) | `63.23% <100.00%> (-0.54%)` | :arrow_down: | | [...omponents/NotificationsDrawer/NotificationItem.tsx](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2857?src=pr&el=tree&filepath=src%2Fcomponents%2FNotificationsDrawer%2FNotificationItem.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL2NvbXBvbmVudHMvTm90aWZpY2F0aW9uc0RyYXdlci9Ob3RpZmljYXRpb25JdGVtLnRzeA==) | `80.00% <100.00%> (+70.00%)` | :arrow_up: | | [src/layouts/DefaultLayout.tsx](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2857?src=pr&el=tree&filepath=src%2Flayouts%2FDefaultLayout.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL2xheW91dHMvRGVmYXVsdExheW91dC50c3g=) | `80.85% <100.00%> (ø)` | | | [src/redux/action-types.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2857?src=pr&el=tree&filepath=src%2Fredux%2Faction-types.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL3JlZHV4L2FjdGlvbi10eXBlcy50cw==) | `100.00% <ø> (ø)` | | | [src/redux/actions.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2857?src=pr&el=tree&filepath=src%2Fredux%2Factions.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL3JlZHV4L2FjdGlvbnMudHM=) | `66.66% <ø> (-5.08%)` | :arrow_down: | | [src/redux/chromeReducers.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2857?src=pr&el=tree&filepath=src%2Fredux%2FchromeReducers.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL3JlZHV4L2Nocm9tZVJlZHVjZXJzLnRz) | `50.70% <ø> (-5.30%)` | :arrow_down: | | [src/redux/index.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2857?src=pr&el=tree&filepath=src%2Fredux%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL3JlZHV4L2luZGV4LnRz) | `100.00% <ø> (ø)` | | | [...ponents/NotificationsDrawer/DrawerPanelContent.tsx](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2857?src=pr&el=tree&filepath=src%2Fcomponents%2FNotificationsDrawer%2FDrawerPanelContent.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL2NvbXBvbmVudHMvTm90aWZpY2F0aW9uc0RyYXdlci9EcmF3ZXJQYW5lbENvbnRlbnQudHN4) | `85.24% <88.88%> (+80.48%)` | :arrow_up: | | [src/components/RootApp/ScalprumRoot.tsx](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2857?src=pr&el=tree&filepath=src%2Fcomponents%2FRootApp%2FScalprumRoot.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL2NvbXBvbmVudHMvUm9vdEFwcC9TY2FscHJ1bVJvb3QudHN4) | `75.32% <66.66%> (ø)` | | | [src/hooks/useChromeServiceEvents.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2857?src=pr&el=tree&filepath=src%2Fhooks%2FuseChromeServiceEvents.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL2hvb2tzL3VzZUNocm9tZVNlcnZpY2VFdmVudHMudHM=) | `47.72% <75.00%> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2857?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) | |