RedHatInsights / insights-chrome

Chroming for Insights apps
MIT License
26 stars 131 forks source link

Enable marking as read in the notification drawer #2862

Closed CodyWMitchell closed 4 months ago

CodyWMitchell commented 4 months ago

Made the following updates to the notification drawer:

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 77.50000% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@88212d3). Learn more about missing BASE report.

:exclamation: Current head 2990d3c differs from pull request most recent head 5924048

Please upload reports for the commit 5924048 to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2862/graphs/tree.svg?width=650&height=150&src=pr&token=GuRwyW1uUf&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights)](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2862?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) ```diff @@ Coverage Diff @@ ## master #2862 +/- ## ========================================= Coverage ? 63.09% ========================================= Files ? 210 Lines ? 4644 Branches ? 914 ========================================= Hits ? 2930 Misses ? 1667 Partials ? 47 ``` | [Files](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2862?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) | Coverage Δ | | |---|---|---| | [src/state/atoms/notificationDrawerAtom.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2862?src=pr&el=tree&filepath=src%2Fstate%2Fatoms%2FnotificationDrawerAtom.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL3N0YXRlL2F0b21zL25vdGlmaWNhdGlvbkRyYXdlckF0b20udHM=) | `77.77% <80.00%> (ø)` | | | [...omponents/NotificationsDrawer/NotificationItem.tsx](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2862?src=pr&el=tree&filepath=src%2Fcomponents%2FNotificationsDrawer%2FNotificationItem.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL2NvbXBvbmVudHMvTm90aWZpY2F0aW9uc0RyYXdlci9Ob3RpZmljYXRpb25JdGVtLnRzeA==) | `76.47% <66.66%> (ø)` | | | [...ponents/NotificationsDrawer/DrawerPanelContent.tsx](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2862?src=pr&el=tree&filepath=src%2Fcomponents%2FNotificationsDrawer%2FDrawerPanelContent.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL2NvbXBvbmVudHMvTm90aWZpY2F0aW9uc0RyYXdlci9EcmF3ZXJQYW5lbENvbnRlbnQudHN4) | `82.71% <80.76%> (ø)` | |
CodyWMitchell commented 4 months ago

/retest

Hyperkid123 commented 4 months ago

/retest