RedHatInsights / insights-chrome

Chroming for Insights apps
MIT License
27 stars 130 forks source link

Jotai migration activeApp #2866

Closed JetyAdam closed 2 months ago

JetyAdam commented 2 months ago

https://issues.redhat.com/browse/RHCLOUD-33325

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.

Project coverage is 63.27%. Comparing base (d17fb3d) to head (e245e8e).

:exclamation: Current head e245e8e differs from pull request most recent head c30af18

Please upload reports for the commit c30af18 to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2866/graphs/tree.svg?width=650&height=150&src=pr&token=GuRwyW1uUf&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights)](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2866?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) ```diff @@ Coverage Diff @@ ## master #2866 +/- ## ========================================== + Coverage 63.09% 63.27% +0.18% ========================================== Files 210 211 +1 Lines 4644 4659 +15 Branches 914 857 -57 ========================================== + Hits 2930 2948 +18 - Misses 1667 1700 +33 + Partials 47 11 -36 ``` | [Files](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2866?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) | Coverage Δ | | |---|---|---| | [src/components/ChromeLink/ChromeLink.tsx](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2866?src=pr&el=tree&filepath=src%2Fcomponents%2FChromeLink%2FChromeLink.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL2NvbXBvbmVudHMvQ2hyb21lTGluay9DaHJvbWVMaW5rLnRzeA==) | `73.91% <100.00%> (ø)` | | | [src/components/RootApp/ScalprumRoot.tsx](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2866?src=pr&el=tree&filepath=src%2Fcomponents%2FRootApp%2FScalprumRoot.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL2NvbXBvbmVudHMvUm9vdEFwcC9TY2FscHJ1bVJvb3QudHN4) | `76.25% <100.00%> (+0.60%)` | :arrow_up: | | [src/redux/action-types.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2866?src=pr&el=tree&filepath=src%2Fredux%2Faction-types.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL3JlZHV4L2FjdGlvbi10eXBlcy50cw==) | `100.00% <ø> (ø)` | | | [src/redux/actions.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2866?src=pr&el=tree&filepath=src%2Fredux%2Factions.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL3JlZHV4L2FjdGlvbnMudHM=) | `62.85% <ø> (-2.01%)` | :arrow_down: | | [src/redux/chromeReducers.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2866?src=pr&el=tree&filepath=src%2Fredux%2FchromeReducers.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL3JlZHV4L2Nocm9tZVJlZHVjZXJzLnRz) | `54.09% <ø> (+0.13%)` | :arrow_up: | | [src/redux/index.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2866?src=pr&el=tree&filepath=src%2Fredux%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL3JlZHV4L2luZGV4LnRz) | `100.00% <ø> (ø)` | | | [src/state/atoms/activeAppAtom.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2866?src=pr&el=tree&filepath=src%2Fstate%2Fatoms%2FactiveAppAtom.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL3N0YXRlL2F0b21zL2FjdGl2ZUFwcEF0b20udHM=) | `100.00% <100.00%> (ø)` | | | [src/state/chromeStore.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2866?src=pr&el=tree&filepath=src%2Fstate%2FchromeStore.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL3N0YXRlL2Nocm9tZVN0b3JlLnRz) | `100.00% <100.00%> (ø)` | | | [src/utils/consts.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2866?src=pr&el=tree&filepath=src%2Futils%2Fconsts.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL3V0aWxzL2NvbnN0cy50cw==) | `85.29% <100.00%> (+12.79%)` | :arrow_up: | | [src/utils/useOuiaTags.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2866?src=pr&el=tree&filepath=src%2Futils%2FuseOuiaTags.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL3V0aWxzL3VzZU91aWFUYWdzLnRz) | `100.00% <100.00%> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2866?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) | | ... and [18 files with indirect coverage changes](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2866/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights)
Hyperkid123 commented 2 months ago

/retest

Hyperkid123 commented 2 months ago

OK. I tried it with v5 apps locally. Its working well. @JetyAdam can you remove the old comments? This can be merged after that.