search

RedHatInsights / insights-chrome

Chroming for Insights apps
MIT License
27 stars 130 forks source link

Update patternfly quickstarts #2870

Closed randomnetcat closed 2 months ago

randomnetcat commented 2 months ago

Update @patternfly/quickstarts to 5.4.0-prerelease.1, which includes this feature, which we added to support https://github.com/RedHatInsights/learning-resources/pull/54. I have tested this locally, and it does indeed resolve the issue of focus being pulled to the drawer when the quickstart changes while the panel is open.

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.03%. Comparing base (c794994) to head (d292a8a).

:exclamation: Current head d292a8a differs from pull request most recent head 6884ccf

Please upload reports for the commit 6884ccf to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2870/graphs/tree.svg?width=650&height=150&src=pr&token=GuRwyW1uUf&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights)](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2870?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) ```diff @@ Coverage Diff @@ ## master #2870 +/- ## ======================================= Coverage 63.03% 63.03% ======================================= Files 210 210 Lines 4612 4612 Branches 913 913 ======================================= Hits 2907 2907 Misses 1658 1658 Partials 47 47 ```