Open randomnetcat opened 2 months ago
Attention: Patch coverage is 0%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 63.66%. Comparing base (
4349edb
) to head (b1b7f2d
).:exclamation: Current head b1b7f2d differs from pull request most recent head a40fa24
Please upload reports for the commit a40fa24 to get more accurate results.
/retest
/retest
Seems like the extensions is messing with e2e cypress/iqe tests:
It appears Cypress is configured to use an ancient User-Agent https://github.com/RedHatInsights/insights-chrome/blob/d17fb3de33d95128a92c8b2fd0f20fa743d50375/cypress.config.ts#L46-L47 . Can that be changed at this point? Not sure what the "chromium issue" is.
We should run the content and banner by UX do double check brand standards. I know from looking the banner doesn't follow PatternFly guidelines and would like to see if they have guidance for us.
@randomnetcat
Can that be changed at this point? Not sure what the "chromium issue" is.
It might be. It's very likely the lib is looking at this. its worth a shot. If that says its chrome 51 its basically an ancient version. Current is 120 or something.
Updated the userAgent. I still have a test failing locally, but it appeared to also be failing on master
?
/retest
There is always one run failing
See RHCLOUD-27572.
The
outdatedBrowser()
call does accept an argument that tells it what browser versions to consider outdated, but I wasn't sure how to even start approaching determining that. For instance, the Patternfly documentation says the supported version for all browser is "latest", which is... less than helpful.