RedHatInsights / insights-chrome

Chroming for Insights apps
MIT License
27 stars 130 forks source link

Duplicate FF context before updating preview env. #2873

Closed Hyperkid123 closed 2 months ago

Hyperkid123 commented 2 months ago

After updating chrome env, the old context is cannibalized and is not sending the initial values.

The update context function does a full replacement instead of updating the current object.

Jira: https://issues.redhat.com/browse/RHCLOUD-33520

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.09%. Comparing base (d9cba3c) to head (cb12c15).

:exclamation: Current head cb12c15 differs from pull request most recent head c973f06

Please upload reports for the commit c973f06 to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2873/graphs/tree.svg?width=650&height=150&src=pr&token=GuRwyW1uUf&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights)](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2873?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) ```diff @@ Coverage Diff @@ ## master #2873 +/- ## ======================================= Coverage 63.09% 63.09% ======================================= Files 210 210 Lines 4644 4644 Branches 914 914 ======================================= Hits 2930 2930 Misses 1667 1667 Partials 47 47 ``` | [Files](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2873?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) | Coverage Δ | | |---|---|---| | [src/state/atoms/releaseAtom.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2873?src=pr&el=tree&filepath=src%2Fstate%2Fatoms%2FreleaseAtom.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL3N0YXRlL2F0b21zL3JlbGVhc2VBdG9tLnRz) | `66.66% <0.00%> (ø)` | |