search

RedHatInsights / insights-chrome

Chroming for Insights apps
MIT License
27 stars 130 forks source link

Use stricter to rule to patch hac link targets. #2880

Closed Hyperkid123 closed 2 months ago

Hyperkid123 commented 2 months ago

Jira: https://issues.redhat.com/browse/RHCLOUD-33375

Use stricter regexp rather than just checking the URL includes the /hac partial.

aneelac22 commented 2 months ago

Lint failures 'MemoryRouter' is defined but never used

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.67%. Comparing base (9e6647e) to head (651e477). Report is 2 commits behind head on master.

:exclamation: Current head 651e477 differs from pull request most recent head 8eb267c

Please upload reports for the commit 8eb267c to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2880/graphs/tree.svg?width=650&height=150&src=pr&token=GuRwyW1uUf&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights)](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2880?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) ```diff @@ Coverage Diff @@ ## master #2880 +/- ## ========================================== + Coverage 63.44% 63.67% +0.23% ========================================== Files 202 202 Lines 4650 4650 Branches 858 858 ========================================== + Hits 2950 2961 +11 + Misses 1689 1679 -10 + Partials 11 10 -1 ``` | [Files](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2880?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) | Coverage Δ | | |---|---|---| | [src/chrome/update-shared-scope.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2880?src=pr&el=tree&filepath=src%2Fchrome%2Fupdate-shared-scope.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL2Nocm9tZS91cGRhdGUtc2hhcmVkLXNjb3BlLnRz) | `57.50% <100.00%> (+27.50%)` | :arrow_up: |