RedHatInsights / insights-chrome

Chroming for Insights apps
MIT License
27 stars 130 forks source link

Evaluate search results visibility. #2883

Closed Hyperkid123 closed 2 months ago

Hyperkid123 commented 2 months ago

Jira: https://issues.redhat.com/browse/RHCLOUD-33633

Runs the chrome evaluateVisibility on search results

Depends on: https://github.com/RedHatInsights/chrome-service-backend/pull/544

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 37.50000% with 25 lines in your changes missing coverage. Please review.

Project coverage is 63.58%. Comparing base (868fdce) to head (b163b47).

:exclamation: Current head b163b47 differs from pull request most recent head 0c325d0

Please upload reports for the commit 0c325d0 to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2883/graphs/tree.svg?width=650&height=150&src=pr&token=GuRwyW1uUf&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights)](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2883?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) ```diff @@ Coverage Diff @@ ## master #2883 +/- ## ========================================== - Coverage 63.67% 63.58% -0.10% ========================================== Files 202 203 +1 Lines 4650 4679 +29 Branches 858 862 +4 ========================================== + Hits 2961 2975 +14 - Misses 1679 1694 +15 Partials 10 10 ``` | [Files](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2883?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) | Coverage Δ | | |---|---|---| | [src/@types/types.d.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2883?src=pr&el=tree&filepath=src%2F%40types%2Ftypes.d.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL0B0eXBlcy90eXBlcy5kLnRz) | `100.00% <100.00%> (ø)` | | | [src/state/atoms/releaseAtom.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2883?src=pr&el=tree&filepath=src%2Fstate%2Fatoms%2FreleaseAtom.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL3N0YXRlL2F0b21zL3JlbGVhc2VBdG9tLnRz) | `71.42% <100.00%> (+4.76%)` | :arrow_up: | | [src/utils/isNavItemVisible.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2883?src=pr&el=tree&filepath=src%2Futils%2FisNavItemVisible.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL3V0aWxzL2lzTmF2SXRlbVZpc2libGUudHM=) | `100.00% <100.00%> (ø)` | | | [src/components/Search/SearchInput.tsx](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2883?src=pr&el=tree&filepath=src%2Fcomponents%2FSearch%2FSearchInput.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL2NvbXBvbmVudHMvU2VhcmNoL1NlYXJjaElucHV0LnRzeA==) | `51.85% <50.00%> (+0.44%)` | :arrow_up: | | [src/state/atoms/localSearchAtom.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2883?src=pr&el=tree&filepath=src%2Fstate%2Fatoms%2FlocalSearchAtom.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL3N0YXRlL2F0b21zL2xvY2FsU2VhcmNoQXRvbS50cw==) | `57.57% <66.66%> (+0.90%)` | :arrow_up: | | [src/utils/localSearch.ts](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2883?src=pr&el=tree&filepath=src%2Futils%2FlocalSearch.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL3V0aWxzL2xvY2FsU2VhcmNoLnRz) | `20.89% <20.68%> (+3.87%)` | :arrow_up: |
Hyperkid123 commented 2 months ago

/retest