search

RedHatInsights / insights-chrome

Chroming for Insights apps
MIT License
27 stars 130 forks source link

Remove unnecessary icon margins if no icon present #2896

Closed jschuler closed 1 month ago

jschuler commented 2 months ago

as part of https://issues.redhat.com/browse/OCMUI-1953 I am updating the OpenShift side nav. I noticed that some unnecessary space is rendered if no icon is present for groups.

Before After
Screenshot 2024-07-11 at 11 51 08 AM Screenshot 2024-07-11 at 11 50 30 AM
app-sre-bot commented 2 months ago

Can one of the admins verify this patch?

Hyperkid123 commented 1 month ago

@jschuler you will have to update the snapshot tests

Hyperkid123 commented 1 month ago

/ok-to-test

jschuler commented 1 month ago

@Hyperkid123 thank you, done