search

RedHatInsights / insights-chrome

Chroming for Insights apps
MIT License
27 stars 130 forks source link

Decrease spacing between search item title/description #2908

Closed randomnetcat closed 1 month ago

randomnetcat commented 1 month ago

As described by the document linked in the comments of RHCLOUD-33948.

This should also fix the bug (described in the same document) where the search title starts spanning three lines (name, pipe, then bundle), which appears to be caused by Javascript loading styles that make the TextContent styling a better match than our overrides.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.10%. Comparing base (5fd849e) to head (9c8c10e).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2908/graphs/tree.svg?width=650&height=150&src=pr&token=GuRwyW1uUf&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights)](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2908?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) ```diff @@ Coverage Diff @@ ## master #2908 +/- ## ========================================== + Coverage 64.09% 64.10% +0.01% ========================================== Files 205 205 Lines 4748 4747 -1 Branches 878 877 -1 ========================================== Hits 3043 3043 + Misses 1655 1654 -1 Partials 50 50 ``` | [Files](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2908?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) | Coverage Δ | | |---|---|---| | [src/components/Search/SearchInput.tsx](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2908?src=pr&el=tree&filepath=src%2Fcomponents%2FSearch%2FSearchInput.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL2NvbXBvbmVudHMvU2VhcmNoL1NlYXJjaElucHV0LnRzeA==) | `51.85% <ø> (ø)` | | | [src/components/Search/SearchTitle.tsx](https://app.codecov.io/gh/RedHatInsights/insights-chrome/pull/2908?src=pr&el=tree&filepath=src%2Fcomponents%2FSearch%2FSearchTitle.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#diff-c3JjL2NvbXBvbmVudHMvU2VhcmNoL1NlYXJjaFRpdGxlLnRzeA==) | `25.00% <50.00%> (+5.00%)` | :arrow_up: |