chore: Disable legacy upload

RedHatInsights / insights-core

Insights Core is a data collection and processing framework used by Red Hat Insights

https://cloud.redhat.com/insights

Apache License 2.0

153 stars 183 forks source link

chore: Disable legacy upload #4160

Open m-horky opened 4 months ago

m-horky commented 4 months ago

All Pull Requests:

Check all that apply:

[x] Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
[ ] Is this PR to correct an issue?
[x] Is this PR an enhancement?

Complete Description of Additions/Changes:

Card ID: CCT-252
Card ID: RHENING-7569

This patch disables the legacy APIs. The code and configuration option will be removed later; this is the first step to get rid of the duplication and differences.

Only the absolutely necessary changes were made to tests; without these removals the suite wouldn't pass.

xiangce commented 4 months ago

Sorry for the abrupt comment before this PR being ready😅, but from the description of RHINENG-7569, the task is also trying to replace the API for legacy_upload=False from cert-api.access.redhat.com/r/insights to cert.console.redhat.com/api. If this is already in your next plan, please ignore this.

BTW, it seems that the CCT-252 is more suitable to be linked to this PR.

m-horky commented 4 months ago

It's fine.

You are right, CCT-252 is a better tracking ticket, I must have missed it.
The API URL will be handled via CCT-258 in a separate PR, we don't want to make too many changes at once to prevent regressions.

xiangce commented 2 months ago

Hi @m-horky - - Sorry for bringing this trouble to you, as we just resolved an urgent bug within the repo. Please rebase the master branch of your fork of insights-core and then rebase this branch again. Please reach out to me for any problems when doing the rebase. Apologize again.