RedHatInsights / insights-core

Insights Core is a data collection and processing framework used by Red Hat Insights
https://cloud.redhat.com/insights
Apache License 2.0
153 stars 183 forks source link

test(ci/cd:py26): download pkgs instead of using personal repo #4251

Closed xiangce closed 1 month ago

xiangce commented 1 month ago

All Pull Requests:

Check all that apply:

Complete Description of Additions/Changes:

Add your description here

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.11%. Comparing base (ab75010) to head (b79dcb8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4251 +/- ## ======================================= Coverage 77.10% 77.11% ======================================= Files 761 761 Lines 41472 41472 Branches 8763 8763 ======================================= + Hits 31978 31980 +2 + Misses 8438 8437 -1 + Partials 1056 1055 -1 ``` | [Flag](https://app.codecov.io/gh/RedHatInsights/insights-core/pull/4251/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/RedHatInsights/insights-core/pull/4251/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) | `77.09% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Glutexo commented 1 month ago

I also tried to run the caplog version of my tests from https://github.com/RedHatInsights/insights-core/pull/4211, https://github.com/RedHatInsights/insights-core/pull/4246, https://github.com/RedHatInsights/insights-core/pull/4248, and https://github.com/RedHatInsights/insights-core/pull/4254 and they all pass with pytest-3.0.6 and catchlog-1.2.2

$ python -m pytest insights/tests/client/connection/test_test_connection.py 
========================================= test session starts =========================================
platform linux -- Python 3.9.18, pytest-3.0.6, py-1.11.0, pluggy-0.4.0
rootdir: /home/insights/insights-core, inifile: setup.cfg
plugins: catchlog-1.2.2
collected 135 items 

insights/tests/client/connection/test_test_connection.py .......................................................................................................................................

===================================== 135 passed in 0.32 seconds ======================================