RedHatInsights / insights-core

Insights Core is a data collection and processing framework used by Red Hat Insights
https://cloud.redhat.com/insights
Apache License 2.0
153 stars 183 forks source link

fix: Update combiner httpd_conf include #4275

Closed wushiqinlou closed 1 day ago

wushiqinlou commented 4 days ago

Signed-off-by: jiazhang jiazhang@redhat.com

rh-pre-commit.version: 2.3.1 rh-pre-commit.check-secrets: ENABLED

All Pull Requests:

Check all that apply:

Complete Description of Additions/Changes:

Options in httpd configuration files are not case sensitive. To avoid configuration files parsing missing, it is necessary to use istartswith("Include") instead of startswith("Include").

Besides Options nginx configuration files are case sensitive, no need to update the nginx combiner.

codecov-commenter commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.19%. Comparing base (1d8b213) to head (7bcee7e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #4275 +/- ## ========================================== - Coverage 77.19% 77.19% -0.01% ========================================== Files 763 763 Lines 41528 41528 Branches 8776 8776 ========================================== - Hits 32059 32057 -2 - Misses 8412 8413 +1 - Partials 1057 1058 +1 ``` | [Flag](https://app.codecov.io/gh/RedHatInsights/insights-core/pull/4275/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/RedHatInsights/insights-core/pull/4275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights) | `77.18% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RedHatInsights#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: