search

RedHatInsights / ocp-advisor-frontend

Insights for OpenShift: OCP Advisor frontend component
https://console.redhat.com/openshift/insights/advisor
Apache License 2.0
3 stars 23 forks source link

fix(RHINENG-8333): correct ouia-type empty state #817

Closed LightOfHeaven1994 closed 2 weeks ago

LightOfHeaven1994 commented 3 weeks ago

some tests are failing because FEC utils haven't been updated yet https://github.com/RedHatInsights/frontend-components/pull/2085

johnsonm325 commented 3 weeks ago

/retest

LightOfHeaven1994 commented 3 weeks ago

/retest

it will fail until ocp-advisor update frontend-components version as it contains some changes for cypress utils https://github.com/RedHatInsights/frontend-components/pull/2085

LightOfHeaven1994 commented 2 weeks ago

so finally I made it work, had to bump utils package too and added redux-mock-store package to dev dependencies otherwise cypress tests were failing locally and on Travis. I also had to fix cypress tests for bulk select as structure looks correct now for bulk menu list and tests have to be updated

gkarat commented 2 weeks ago

:tada: This PR is included in version 1.45.9 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: