search

RedHatInsights / ocp-advisor-frontend

Insights for OpenShift: OCP Advisor frontend component
https://console.redhat.com/openshift/insights/advisor
Apache License 2.0
3 stars 23 forks source link

[Snyk] Upgrade @reduxjs/toolkit from 2.2.7 to 2.3.0 #837

Open gkarat opened 1 week ago

gkarat commented 1 week ago

snyk-top-banner

Snyk has created this PR to upgrade @reduxjs/toolkit from 2.2.7 to 2.3.0.

:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

Release notes
Package name: @reduxjs/toolkit
  • 2.3.0 - 2024-10-14

    This feature release adds a new RTK Query upsertQueryEntries util to batch-upsert cache entries more efficiently, passes through additional values for use in prepareHeaders, and exports additional TS types around query options and selectors.

    Changelog

    upsertQueryEntries

    RTK Query already had an upsertQueryData thunk that would upsert a single cache entry. However, some users wanted to upsert many cache entries (potentially hundreds or thousands), and found that upsertQueryData had poor performance in those cases. This is because upsertQueryData runs the full async request handling sequence, including dispatching both pending and fulfilled actions, each of which run the main reducer and update store subscribers. That means there's 2N store / UI updates per item, so upserting hundreds of items becomes extremely perf-intensive.

    RTK Query now includes an api.util.upsertQueryEntries action that is meant to handle the batched upsert use case more efficiently. It's a single synchronous action that accepts an array of many {endpointName, arg, value} entries to upsert. This results in a single store update, making this vastly better for performance vs many individual upsertQueryData calls.

    We see this as having two main use cases. The first is prefilling the cache with data retrieved from storage on app startup (and it's worth noting that upsertQueryEntries can accept entries for many different endpoints as part of the same array).

    The second is to act as a "pseudo-normalization" tool. RTK Query is not a "normalized" cache. However, there are times when you may want to prefill other cache entries with the contents of another endpoint, such as taking the results of a getPosts list endpoint response and prefilling the individual getPost(id) endpoint cache entries, so that components that reference an individual item endpoint already have that data available.

    Currently, you can implement the "pseudo-normalization" approach by dispatching upsertQueryEntries in an endpoint lifecycle, like this:

    const api = createApi({
  endpoints: (build) => ({
    getPosts: build.query<Post[], void>({
      query: () => '/posts',
      async onQueryStarted(_, { dispatch, queryFulfilled }) {
        const res = await queryFulfilled
        const posts = res.data

        // Pre-fill the individual post entries with the results
        // from the list endpoint query
        dispatch(
          api.util.upsertQueryEntries(
            posts.map((post) => ({
              endpointName: 'getPost',
              arg: { id: post.id },
              value: post,
            })),
          ),
        )
      },
    }),
    getPost: build.query<Post, Pick<Post, 'id'>>({
      query: (post) => `post/${post.id}`,
    }),
  }),
})

    Down the road we may add a new option to query endpoints that would let you provide the mapping function and have it automatically update the corresponding entries.

    For additional comparisons between upsertQueryData and upsertQueryEntries, see the upsertQueryEntries API reference.

    prepareHeaders Options

    The prepareHeaders callback for fetchBaseQuery now receives two additional values in the api argument:

    • arg: the URL string or FetchArgs object that was passed in to fetchBaseQuery for this endpoint
    • extraOptions: any extra options that were provided to the base query

    Additional TS Types

    We've added a TypedQueryStateSelector type that can be used to pre-type selectors for use with selectFromResult:

    const typedSelectFromResult: TypedQueryStateSelector<
  PostsApiResponse,
  QueryArgument,
  BaseQueryFunction,
  SelectedResult
> = (state) => ({ posts: state.data?.posts ?? EMPTY_ARRAY })

function PostsList() {
  const { posts } = useGetPostsQuery(undefined, {
    selectFromResult: typedSelectFromResult,
  })
}

    We've also exported several additional TS types around base queries and tag definitions.

    What's Changed

    Full Changelog: v2.2.8...v2.3.0

  • 2.2.8 - 2024-10-08

    This bugfix release fixes a long-standing issue with RTK Query lazy query triggers returning stale data in some cases, fixes an error handling issue in RTK Query, and exports additional TS types.

    Changelog

    Lazy Query Trigger Handling

    We'd had a couple long-standing issues reporting that const result = await someLazyQueryTrigger() sometimes returned stale data, especially if a mutation had just invalidated that query's tag.

    We finally got a good repro of this issue and identified it as a mis-written call inside of the middleware that skipped past the necessary handling to activate the correct query status tracking in that scenario. This should now be fixed.

    Other Changes

    Timeout handling in RTKQ endpoints should now correctly throw a timeout-related error instead of an AbortError.

    Base queries now have access to the current queryCacheKey value so it can be used in deciding query logic.

    We've exported several more TS types related to query options, as some users have been depending on those even though they previously weren't part of the public API.

    What's Changed

    Full Changelog: v2.2.7...v2.2.8

  • 2.2.7 - 2024-07-27
from @reduxjs/toolkit GitHub release notes

[!IMPORTANT]

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 8.27%. Comparing base (292096c) to head (1759b52).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #837 +/- ## ====================================== Coverage 8.27% 8.27% ====================================== Files 68 68 Lines 3953 3953 Branches 864 864 ====================================== Hits 327 327 Misses 3626 3626 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.