RedHatInsights / sources-ui

Static deploy repo: https://github.com/RedHatInsights/sources-ui-deploy
Apache License 2.0
5 stars 47 forks source link

Allow users with read permissions to view Integrations tabs #1207

Closed CodyWMitchell closed 7 months ago

CodyWMitchell commented 7 months ago

Description

Update the /settings/integrations page so that the Communications, Reporting and Automation, and Webhooks tabs are visible for users with integrations:endpoints:read or integrations:*:* permissions instead of only Org Admins.

RHCLOUD-30431

(Merge only after https://github.com/RedHatInsights/notifications-frontend/pull/543 is merged)


Screenshots

image


Checklist ☑️

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 97.59%. Comparing base (a0231d6) to head (030dc82).

:exclamation: Current head 030dc82 differs from pull request most recent head 7b0118b. Consider uploading reports for the commit 7b0118b to get more accurate results

Files Patch % Lines
src/redux/user/actions.js 33.33% 5 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1207 +/- ## ========================================== - Coverage 97.74% 97.59% -0.16% ========================================== Files 184 184 Lines 3686 3698 +12 Branches 1049 1051 +2 ========================================== + Hits 3603 3609 +6 - Misses 77 82 +5 - Partials 6 7 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

karelhala commented 7 months ago

Looks like there's ERR_UNHANDLED_REJECTION in your code somwhere.