RedHatInsights / sources-ui

Static deploy repo: https://github.com/RedHatInsights/sources-ui-deploy
Apache License 2.0
5 stars 47 forks source link

hccdoc-2342 Neutral filenames, CUR>data export, and OCI link fix #1211

Closed neal-timpe closed 5 months ago

neal-timpe commented 5 months ago

Description

This fixes links and link text issues the integration wizard in three parts. First, in conjunction with hccdoc-2342, this changes the filenames in some cost management docs so that they don't have HCS in the URL and makes the links from the sources UI point to the correct locations.

For HCCDOC-2389, it changes CUR to data export to track with a change made in HCS.

And as part of HCSDOC-2363, it fixes a naked URL link to the docs and covers it with appropriate link text.


Screenshots

Oracle cloud

After:

It should say after In your Oracle Cloud account, create a VM and run a script the documentation: Replicating reports to a bucket


Checklist ☑️

app-sre-bot commented 5 months ago

Can one of the admins verify this patch?

neal-timpe commented 5 months ago

@fhlavac I feel like the checklist is filled in, but I can't figure out why the linter threw an error on whitespace that I didn't change. It's my first PR for this project, so sorry about that.

fhlavac commented 5 months ago

I cannot see any more issues, running the lint script with --fix option should help. @neal-timpe have you encountered anything else? Thank you 🙂

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.75%. Comparing base (51e2ae0) to head (f212167).

:exclamation: Current head f212167 differs from pull request most recent head 4c7077e

Please upload reports for the commit 4c7077e to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1211 +/- ## ======================================= Coverage 97.75% 97.75% ======================================= Files 184 184 Lines 3702 3702 Branches 1053 1053 ======================================= Hits 3619 3619 Misses 77 77 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

neal-timpe commented 5 months ago

Thanks! @fhlavac My local linter was coming up with some other nonsense that I couldn't figure out and I didn't want to keep committing, but it looks like it came out okay with your help! :)