Refactor launch app AWS integration

amirfefer commented 3 months ago

Description

Currently, our AWS integration wizard guides users through creating a policy and role resources, attaching them manually via the AWS CLI, and entering the ARN.

By leveraging an AWS CloudFormation stack template, we can streamline this process. Users will be able to achieve this with a simple redirection to AWS console with a dedicated template, eliminating the need for CLI commands or copy any JSON file. The ARN will be retrieved automatically, simplifying the integration with our service.

HMS-4041

Screenshots

Before:

https://github.com/RedHatInsights/sources-ui/assets/11807069/c8589562-2dd4-4b12-a2be-8198f97bee66

After:

https://github.com/RedHatInsights/sources-ui/assets/11807069/7b0b2ce4-6c55-486c-b9d8-efd15ca1d069

Checklist ☑️

[x] PR only fixes one issue or story
[ ] Change reviewed for extraneous code
[ ] UI best practices adhered to
[ ] Commits squashed and meaningfully named
[ ] All PR checks pass locally (build, lint, test, E2E)

[ ] (Optional) QE: Needs QE attention (OUIA changed, perceived impact to tests, no test coverage)
[ ] (Optional) QE: Has been mentioned
[ ] (Optional) UX: Needs UX attention (end user UX modified, missing designs)
[x] (Optional) UX: Has been mentioned

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 97.08%. Comparing base (431c63c) to head (260dfe6).

:exclamation: Current head 260dfe6 differs from pull request most recent head 5d8a024

Please upload reports for the commit 5d8a024 to get more accurate results.

Files	Patch %	Lines
...eWizard/hardcodedComponents/aws/provisioningArn.js	33.33%	8 Missing and 2 partials :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1214 +/- ## ========================================== - Coverage 97.75% 97.08% -0.68% ========================================== Files 184 184 Lines 3702 3701 -1 Branches 1053 1049 -4 ========================================== - Hits 3619 3593 -26 - Misses 77 97 +20 - Partials 6 11 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fhlavac commented 3 months ago

@amirfefer it looks like the tests need to be updated. Also, did anyone from UX review the changes?

I noticed especially the button not being in sync with what we have for Azure: Snímek obrazovky 2024-06-28 v 12 00 51 vs

And also the tooltip looks a bit weird Snímek obrazovky 2024-06-28 v 12 01 35

maryshak1996 commented 3 months ago

Hey there @fhlavac asked me to do a quick UX review here -- overall looks good, but I've got a few suggestions:

We don't have to capitalize the 'r' in 'roles' every time we say 'IAM Role' -- we can just say 'IAM role'
For actions that a user clicks on we should use '[words]' as well as bold the text. For example, instead of "Click on Connect AWS to open AWS...", we should say "Click on 'Connect AWS' to open AWS..."
Make the button will width to match the lighthouse example
Instead of having a very large tooltip that expands beyond the size of the modal itself, we could do an expandable section that says 'See role permissions'. It would be closed by default (like you see in the first screenshot below) but then could be triggered open if the user would like (second screenshot).

Hope this helps!

amirfefer commented 3 months ago

Thanks @fhlavac and @maryshak1996! I've addressed your comments

Screenshot 2024-07-02 at 21 02 33

fhlavac commented 3 months ago

/retest

fhlavac commented 3 months ago

This should fix the build, just we need to bump the FEC version when it is released https://github.com/RedHatInsights/frontend-components/pull/2028

fhlavac commented 3 months ago

@redhat-cloud-services/tsc-transform-imports/v/1.0.13

ezr-ondrej commented 3 months ago

@fhlavac should we bump the version in this PR?

fhlavac commented 3 months ago

@ezr-ondrej yes, please

ezr-ondrej commented 3 months ago

/retest

ezr-ondrej commented 3 months ago

ouch: Error: building at STEP "COPY LICENSE /licenses/": checking on sources under "/var/lib/jenkins/workspace/RedHatInsights-sources-ui-pr-check/build/container_workspace": copier: stat: "/LICENSE": no such file or directory

ezr-ondrej commented 3 months ago

Trying to fix it here: https://github.com/RedHatInsights/sources-ui/pull/1216

ezr-ondrej commented 3 months ago

@RedHatInsights/platform-experience this would be amazing to have if you get to it :pray:

RedHatInsights / sources-ui