Closed radekkaluzik closed 1 week ago
/retest
Per the ticket description, these should be probably hidden as well
/retest
Per the ticket description, these should be probably hidden as well
All those things are hidden. Karel created testing account "integrations-frontend" to simulate unauthorized user. All those elements you've highlighted are hidden as requested.
Per the ticket description, these should be probably hidden as well
Snímek obrazovky 2024-10-09 v 9 57 35 All those things are hidden. Karel created testing account "integrations-frontend" to simulate unauthorized user. All those > elements you've highlighted are hidden as requested.
Oh yeah, I see it now, I have overwritten the permissions in one place and affected only the dropdown. Just seeing this now I wonder if it won't be more efficient to do the permission check in one place and not duplicate the code in two places. Something similar is already being done here https://github.com/RedHatInsights/sources-ui/blob/master/src/pages/Sources.js#L71 so maybe we could enhance it, remove the other checks and just pass the result of the permission check down to the header and overview content. What do you think?
Authorized user
Unauthorized user
Description
Integrations landing page hides "create new integration" functionality for unauthorized users
RHCLOUD-35362
Screenshots
Checklist ☑️